Add WebDriver BiDi extension #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WebDriver BiDi extension
OrKoN
commented
Mar 20, 2024
OrKoN
commented
Mar 20, 2024
nondebug
requested changes
Mar 28, 2024
|
|
||
| ## The bluetooth module ## {#bluetooth-module} | ||
|
|
||
| The bluetooth module contains commands for managing the remote end Bluetooth behavior. |
There was a problem hiding this comment.
Wrap "bluetooth" with <dfn>:
The <dfn>bluetooth</dfn> module contains commands
There was a problem hiding this comment.
I have removed the definition because it conflicts with another definition with the same id. We also usually do not need the definition for the module, is there a place you want to reference it?
|
thanks for reviewing @nondebug addressed the comments, PTAL |
nondebug
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
This lgtm but please let @reillyeon take a look before submitting
reillyeon
requested changes
Apr 5, 2024
Co-authored-by: Reilly Grant <[email protected]>
Co-authored-by: Reilly Grant <[email protected]>
Co-authored-by: Reilly Grant <[email protected]>
Co-authored-by: Reilly Grant <[email protected]>
OrKoN
commented
Apr 6, 2024
|
Could someone please approve the Build, Validate and Deploy workflow? (so that I could address any validation errors that might be there) |
reillyeon
reviewed
Apr 10, 2024
reillyeon
approved these changes
Apr 10, 2024
Co-authored-by: Reilly Grant <[email protected]>
|
@reillyeon @alexnj @nondebug is there anything blocking us from landing the spec change? |
github-actions bot
added a commit
that referenced
this pull request
Apr 23, 2024
SHA: 35c034e Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Apr 23, 2024
SHA: 35c034e Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Apr 23, 2024
SHA: 35c034e Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
that referenced
this pull request
Apr 23, 2024
SHA: 35c034e Reason: push, by reillyeon Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #616
Preview | Diff